Skip to content

feat: sort ScMap entries by key in Scv.toMap following Soroban runtime ordering#766

Merged
overcat merged 6 commits intomasterfrom
feat/sort-scmap-entries-by-key
Mar 4, 2026
Merged

feat: sort ScMap entries by key in Scv.toMap following Soroban runtime ordering#766
overcat merged 6 commits intomasterfrom
feat/sort-scmap-entries-by-key

Conversation

@overcat
Copy link
Member

@overcat overcat commented Mar 4, 2026

No description provided.

@codecov
Copy link

codecov bot commented Mar 4, 2026

Codecov Report

❌ Patch coverage is 93.78531% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.42%. Comparing base (64abf03) to head (1c8bf8a).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...main/java/org/stellar/sdk/scval/ScvComparator.java 93.71% 7 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #766      +/-   ##
============================================
+ Coverage     81.01%   81.42%   +0.40%     
- Complexity     1417     1478      +61     
============================================
  Files           218      219       +1     
  Lines          5400     5577     +177     
  Branches        540      567      +27     
============================================
+ Hits           4375     4541     +166     
- Misses          721      728       +7     
- Partials        304      308       +4     
Files with missing lines Coverage Δ
src/main/java/org/stellar/sdk/scval/Scv.java 97.95% <100.00%> (+0.04%) ⬆️
src/main/java/org/stellar/sdk/scval/ScvMap.java 70.58% <100.00%> (+1.83%) ⬆️
...main/java/org/stellar/sdk/scval/ScvComparator.java 93.71% <93.71%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@overcat overcat force-pushed the feat/sort-scmap-entries-by-key branch 2 times, most recently from 9e463d4 to c8333cc Compare March 4, 2026 02:47
@overcat overcat force-pushed the feat/sort-scmap-entries-by-key branch from aa519e2 to 2f6a820 Compare March 4, 2026 02:56
@overcat overcat enabled auto-merge (squash) March 4, 2026 07:21
@overcat overcat merged commit 3610dc6 into master Mar 4, 2026
9 checks passed
@overcat overcat deleted the feat/sort-scmap-entries-by-key branch March 4, 2026 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant